gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET#132564
Merged
Fidget-Spinner merged 13 commits intopython:mainfrom Apr 27, 2025
Merged
gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET#132564Fidget-Spinner merged 13 commits intopython:mainfrom
sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET#132564Fidget-Spinner merged 13 commits intopython:mainfrom
Conversation
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Contributor
Author
|
@brandtbucher Hi Brandt, I might need some help here. I have already optimization path for But I got a little bit confused for |
Member
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli
changed the title
sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICE
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli
changed the title
sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICEsym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Fidget-Spinner
approved these changes
Apr 26, 2025
Signed-off-by: Manjusaka <me@manjusaka.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is under developing, not ready for review